falsepattern/ZigBrains
1
0
Fork 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity

fix: Unnecessary URL boxing in msvc debugger metadata

Browse source
This commit is contained in:
FalsePattern 2024-07-22 14:45:11 +02:00
parent e5a8616aa3
commit e2e13e5f84
Signed by: falsepattern
GPG key ID: E930CDEC50C50E23
1 changed files with 3 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
modules/debugger/src/main/java/com/falsepattern/zigbrains/debugger/toolchain/ZigDebuggerToolchainService.java
View file

@ -232,7 +232,7 @@ public final class ZigDebuggerToolchainService {
if (!accepted.get()) if (!accepted.get())
yield null; yield null;
yield List.of(new DownloadableDebuggerBinary(msvcUrl.url.toString(), MSVC_PROPERTY_NAME, msvcUrl.version, "extension/debugAdapters/vsdbg/bin")); yield List.of(new DownloadableDebuggerBinary(msvcUrl.url, MSVC_PROPERTY_NAME, msvcUrl.version, "extension/debugAdapters/vsdbg/bin"));
} }
}; };
@ -420,16 +420,10 @@ public final class ZigDebuggerToolchainService {
if (url == null || version == null) if (url == null || version == null)
return null; return null;
try { return new MSVCUrl(url, version, props.getProperty("dialogTitle"), props.getProperty("dialogBody"), props.getProperty("dialogLink"));
return new MSVCUrl(new URL(url), version, props.getProperty("dialogTitle"), props.getProperty("dialogBody"), props.getProperty("dialogLink"));
} catch (MalformedURLException e) {
//TODO logging
e.printStackTrace();
return null;
}
} }
private record MSVCUrl(URL url, String version, String dialogTitle, String dialogBody, String dialogLink) {} private record MSVCUrl(String url, String version, String dialogTitle, String dialogBody, String dialogLink) {}
private static String fileName(String url) { private static String fileName(String url) {
return url.substring(url.lastIndexOf('/') + 1); return url.substring(url.lastIndexOf('/') + 1);